Skip to content

feat(screenshot): Add public API for custom masking#6953

Closed
philprime wants to merge 1 commit intomainfrom
philprime/public-screenshot-api
Closed

feat(screenshot): Add public API for custom masking#6953
philprime wants to merge 1 commit intomainfrom
philprime/public-screenshot-api

Conversation

@philprime
Copy link
Member

@philprime philprime commented Dec 2, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@philprime philprime self-assigned this Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Add public API for custom masking ([#6953](https://github.com/getsentry/sentry-cocoa/pull/6953))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 01522db

@philprime philprime mentioned this pull request Dec 2, 2025
Merged
6 tasks
@philprime
Copy link
Member Author

philprime commented Feb 12, 2026

Closing this as it has no priority right now

@philprime philprime closed this Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.596%. Comparing base (bc5a029) to head (01522db).
⚠️ Report is 239 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Swift/Public/SentryScreenshotApi.swift 0.000% 47 Missing ⚠️
Sources/Sentry/SentryScreenshotIntegration.m 0.000% 27 Missing ⚠️
Sources/Sentry/SentrySDKInternal.m 0.000% 6 Missing ⚠️
Sources/Swift/Helper/SentrySDK.swift 0.000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6953       +/-   ##
=============================================
+ Coverage   85.054%   85.596%   +0.541%     
=============================================
  Files          453       449        -4     
  Lines        27681     37448     +9767     
  Branches     12166     17386     +5220     
=============================================
+ Hits         23544     32054     +8510     
- Misses        4088      5346     +1258     
+ Partials        49        48        -1
Files with missing lines Coverage Δ
Sources/Swift/Helper/SentrySDK.swift 82.500% <0.000%> (-1.760%) ⬇️
Sources/Sentry/SentrySDKInternal.m 83.582% <0.000%> (-1.499%) ⬇️
Sources/Sentry/SentryScreenshotIntegration.m 58.227% <0.000%> (-30.962%) ⬇️
Sources/Swift/Public/SentryScreenshotApi.swift 0.000% <0.000%> (ø)

... and 417 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5a029...01522db. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann will be requested when the pull request is marked ready for review philipphofmann is a code owner

@noahsmartin noahsmartin Awaiting requested review from noahsmartin noahsmartin will be requested when the pull request is marked ready for review noahsmartin is a code owner

@itaybre itaybre Awaiting requested review from itaybre itaybre will be requested when the pull request is marked ready for review itaybre is a code owner

Assignees

@philprime philprime

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@philprime